Skip to content

Add Tasmota sensor#41483

Merged
emontnemery merged 5 commits into
home-assistant:devfrom
emontnemery:tasmota_sensor
Oct 12, 2020
Merged

Add Tasmota sensor#41483
emontnemery merged 5 commits into
home-assistant:devfrom
emontnemery:tasmota_sensor

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Oct 8, 2020

Proposed change

Add Tasmota sensor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Comment thread homeassistant/components/tasmota/discovery.py Outdated
Comment thread homeassistant/components/tasmota/discovery.py Outdated
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Comment thread homeassistant/components/tasmota/sensor.py
Comment thread homeassistant/components/tasmota/sensor.py Outdated
@emontnemery emontnemery merged commit 84cb00b into home-assistant:dev Oct 12, 2020
Comment thread homeassistant/components/tasmota/sensor.py
@emontnemery emontnemery deleted the tasmota_sensor branch October 14, 2020 17:49
weissm pushed a commit to weissm/core that referenced this pull request Oct 16, 2020
* Add Tasmota sensor

* Remove useless try-except

* Bump hatasmota to 0.0.11

* Apply suggestions from code review

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>

* Sort dict constants

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants