Skip to content

Return attribute dict directly without temporary variable v3#41502

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
springstan:remove-temp-dict-clean-up
Oct 8, 2020
Merged

Return attribute dict directly without temporary variable v3#41502
MartinHjelmare merged 1 commit intohome-assistant:devfrom
springstan:remove-temp-dict-clean-up

Conversation

@springstan
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Just some quick clean up to remove using unnecessary attribute dictionary and then immediately returning them.
Continuation of #41271

# Before
def attributes(self):
    attr = {"key": "value"}
    return attr

# After
def attributes(self):
    return {"key": "value"}

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
n/a

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @pvizeli, @danielperna84, mind taking a look at this pull request as its been labeled with an integration (homematic) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @swails, mind taking a look at this pull request as its been labeled with an integration (lutron_caseta) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Contributor

@danielperna84 danielperna84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for HomeMatic. 👍

Copy link
Copy Markdown
Contributor

@swails swails left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartinHjelmare MartinHjelmare merged commit 9161789 into home-assistant:dev Oct 8, 2020
@springstan springstan deleted the remove-temp-dict-clean-up branch October 8, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants