Return attribute dict directly without temporary variable v2#41271
Merged
springstan merged 4 commits intohome-assistant:devfrom Oct 6, 2020
Merged
Return attribute dict directly without temporary variable v2#41271springstan merged 4 commits intohome-assistant:devfrom
springstan merged 4 commits intohome-assistant:devfrom
Conversation
balloob
reviewed
Oct 6, 2020
| currservice_end: is in the format '21:00'. | ||
| """ | ||
| attributes = {} | ||
| if not self.e2_box.in_standby: |
Member
There was a problem hiding this comment.
I know it's not for this PR, but the code would look more beautiful if we turn it around: if standby: return {}, giving more line length for the actual code.
Member
There was a problem hiding this comment.
This ofc is not just in this case, but in many of these cases in this PR. Anyway, not really for this PR, feel free to merge without.
Member
Author
There was a problem hiding this comment.
Oh gotcha. Will open a separate PR to clean up these cases.
This was referenced Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Just some quick clean up to remove using unnecessary attribute dictionary and then immediately returning them.
Continuation of #41206
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: