Skip to content

Refactor deCONZ tests#41362

Merged
Kane610 merged 2 commits intohome-assistant:devfrom
Kane610:deconz-fix_comments_from_41015
Oct 6, 2020
Merged

Refactor deCONZ tests#41362
Kane610 merged 2 commits intohome-assistant:devfrom
Kane610:deconz-fix_comments_from_41015

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Oct 6, 2020

Breaking change

Proposed change

Follow comments from @MartinHjelmare from #41015, this is more or less just a search and replace

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare changed the title deCONZ fix comments from 41015 Refactor deCONZ tests Oct 6, 2020
@Kane610 Kane610 force-pushed the deconz-fix_comments_from_41015 branch from 15fccd8 to 4759dca Compare October 6, 2020 21:08
@Kane610 Kane610 merged commit cbb4324 into home-assistant:dev Oct 6, 2020
@Kane610 Kane610 deleted the deconz-fix_comments_from_41015 branch October 6, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants