Skip to content

Clean deCONZ tests to depend less on integration code#41015

Merged
MartinHjelmare merged 9 commits intohome-assistant:devfrom
Kane610:deconz-fix_comment_from_40807
Oct 2, 2020
Merged

Clean deCONZ tests to depend less on integration code#41015
MartinHjelmare merged 9 commits intohome-assistant:devfrom
Kane610:deconz-fix_comment_from_40807

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Oct 1, 2020

Breaking change

Proposed change

Clean up tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current changes are good. There are more things to do though for the future.

Comment thread tests/components/deconz/test_binary_sensor.py
Comment thread tests/components/deconz/test_binary_sensor.py
Comment thread tests/components/deconz/test_binary_sensor.py
@MartinHjelmare MartinHjelmare changed the title deCONZ fix Martins comment from 40807 Clean deCONZ tests to depend less on integration code Oct 2, 2020
@MartinHjelmare MartinHjelmare merged commit 5528562 into home-assistant:dev Oct 2, 2020
@Kane610 Kane610 deleted the deconz-fix_comment_from_40807 branch October 2, 2020 10:28
@Kane610 Kane610 mentioned this pull request Oct 6, 2020
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants