Skip to content

Use name reference and fix already_configured string for GIOS integration #41323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
Oct 6, 2020
Merged

Use name reference and fix already_configured string for GIOS integration #41323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions homeassistant/components/gios/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"title": "GIO\u015a (Polish Chief Inspectorate Of Environmental Protection)",
"description": "Set up GIO\u015a (Polish Chief Inspectorate Of Environmental Protection) air quality integration. If you need help with the configuration have a look here: https://www.home-assistant.io/integrations/gios",
"data": {
"name": "Name of the integration",
"name": "[%key:common::config_flow::data::name%]",
"station_id": "ID of the measuring station"
}
}
Expand All @@ -16,7 +16,7 @@
"cannot_connect": "[%key:common::config_flow::error::cannot_connect%]"
},
"abort": {
"already_configured": "[%key:common::config_flow::abort::already_configured_service%]"
"already_configured": "[%key:common::config_flow::abort::already_configured_service%] for this measuring station"
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use already_configured_location when that is available?

Copy link
Copy Markdown
Member Author

@bieniu bieniu Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, already_configured_location doesn't fit here because this integration uses station_id and not station coordinates.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Practically the id means location, right? It's just that we don't ask for coordinates in the form. But ok.

Copy link
Copy Markdown
Member Author

@bieniu bieniu Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Practically yes. I can change that if you think that we should use already_configured_location here.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As codeowner you should decide what fits best for the integration.

Copy link
Copy Markdown
Member Author

@bieniu bieniu Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking about it, I admit that already_configured_location will fit here. I'll change it.

}
}
}