Use name reference and fix already_configured string for GIOS integration#41323
Use name reference and fix already_configured string for GIOS integration#41323balloob merged 1 commit intohome-assistant:devfrom bieniu:gios-translations
Conversation
probot-home-assistant
Bot
added
Hacktoberfest
code-quality
integration: gios
small-pr
| }, | ||
| "abort": { | ||
| "already_configured": "[%key:common::config_flow::abort::already_configured_service%]" | ||
| "already_configured": "[%key:common::config_flow::abort::already_configured_service%] for this measuring station" |
There was a problem hiding this comment.
Should we use already_configured_location when that is available?
There was a problem hiding this comment.
IMO, already_configured_location doesn't fit here because this integration uses station_id and not station coordinates.
There was a problem hiding this comment.
Practically the id means location, right? It's just that we don't ask for coordinates in the form. But ok.
There was a problem hiding this comment.
Practically yes. I can change that if you think that we should use already_configured_location here.
There was a problem hiding this comment.
As codeowner you should decide what fits best for the integration.
There was a problem hiding this comment.
After thinking about it, I admit that already_configured_location will fit here. I'll change it.
4 participants
Breaking change
Proposed change
Use
namereference and fixalready_configuredstring.Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: