Skip to content

Improve switch template tests, remove common test helpers #41322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
Oct 6, 2020
Merged

Improve switch template tests, remove common test helpers #41322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 33 additions & 10 deletions tests/components/template/test_switch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,15 @@
import pytest

from homeassistant import setup
from homeassistant.const import STATE_OFF, STATE_ON, STATE_UNAVAILABLE
from homeassistant.components.switch import DOMAIN as SWITCH_DOMAIN
from homeassistant.const import (
ATTR_ENTITY_ID,
SERVICE_TURN_OFF,
SERVICE_TURN_ON,
STATE_OFF,
STATE_ON,
STATE_UNAVAILABLE,
)
from homeassistant.core import CoreState, State
from homeassistant.setup import async_setup_component

Expand All @@ -13,7 +21,6 @@
mock_component,
mock_restore_cache,
)
from tests.components.switch import common


@pytest.fixture
Expand Down Expand Up @@ -418,8 +425,12 @@ async def test_on_action(hass, calls):
state = hass.states.get("switch.test_template_switch")
assert state.state == STATE_OFF

await common.async_turn_on(hass, "switch.test_template_switch")
await hass.async_block_till_done()
await hass.services.async_call(
SWITCH_DOMAIN,
SERVICE_TURN_ON,
{ATTR_ENTITY_ID: "switch.test_template_switch"},
blocking=True,
)

assert len(calls) == 1

Expand Down Expand Up @@ -454,8 +465,12 @@ async def test_on_action_optimistic(hass, calls):
state = hass.states.get("switch.test_template_switch")
assert state.state == STATE_OFF

await common.async_turn_on(hass, "switch.test_template_switch")
await hass.async_block_till_done()
await hass.services.async_call(
SWITCH_DOMAIN,
SERVICE_TURN_ON,
{ATTR_ENTITY_ID: "switch.test_template_switch"},
blocking=True,
)

state = hass.states.get("switch.test_template_switch")
assert len(calls) == 1
Expand Down Expand Up @@ -494,8 +509,12 @@ async def test_off_action(hass, calls):
state = hass.states.get("switch.test_template_switch")
assert state.state == STATE_ON

await common.async_turn_off(hass, "switch.test_template_switch")
await hass.async_block_till_done()
await hass.services.async_call(
SWITCH_DOMAIN,
SERVICE_TURN_OFF,
{ATTR_ENTITY_ID: "switch.test_template_switch"},
blocking=True,
)

assert len(calls) == 1

Expand Down Expand Up @@ -530,8 +549,12 @@ async def test_off_action_optimistic(hass, calls):
state = hass.states.get("switch.test_template_switch")
assert state.state == STATE_ON

await common.async_turn_off(hass, "switch.test_template_switch")
await hass.async_block_till_done()
await hass.services.async_call(
SWITCH_DOMAIN,
SERVICE_TURN_OFF,
{ATTR_ENTITY_ID: "switch.test_template_switch"},
blocking=True,
)

state = hass.states.get("switch.test_template_switch")
assert len(calls) == 1
Expand Down