Skip to content

Improve switch template tests, remove common test helpers#41322

Merged
balloob merged 1 commit intodevfrom
frenck-2020-0876
Oct 6, 2020
Merged

Improve switch template tests, remove common test helpers#41322
balloob merged 1 commit intodevfrom
frenck-2020-0876

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Oct 6, 2020

Proposed change

Small improvements to the template tests; switch platform.

Removes the use of common test helpers and replaces the occurrences with direct service calls.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @PhracturedBlue, @tetienne, mind taking a look at this pull request as its been labeled with an integration (template) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob merged commit 357a0e9 into dev Oct 6, 2020
@balloob balloob deleted the frenck-2020-0876 branch October 6, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants