Add telegram_sent event#41159
Merged
bdraco merged 5 commits intohome-assistant:devfrom Oct 29, 2020
Merged
Conversation
8 tasks
hfurubotten
reviewed
Oct 3, 2020
Contributor
hfurubotten
left a comment
There was a problem hiding this comment.
Some thoughts I had while reading the code, hope they might turn out to be useful improvements 🙂
Co-authored-by: Heine Furubotten <hfurubotten@users.noreply.github.com>
ShaneQi
reviewed
Oct 9, 2020
Contributor
ShaneQi
left a comment
There was a problem hiding this comment.
I don't see any problem in the code change.
But I'm not in the place to approve this proposal.
17 tasks
bdraco
reviewed
Oct 18, 2020
bdraco
approved these changes
Oct 18, 2020
Contributor
|
Any Love for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
For the
telegram_botcomponent, for some automations it is necessary to edit or delete messages in history that the bot sent.As a solution, I propose a new
telegram_sentevent with the optionalmessage_tagparameter.The
message_tagparameter allows you to distinguish (filter) automation flows.Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
Feature telegram_sent home-assistant.io#14853
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: