Skip to content

Add the Feature of Reordering Shopping List by Moving Up or Down an Item#41565

Closed
ShaneQi wants to merge 2 commits intohome-assistant:devfrom
ShaneQi:feature/shopping-list-move-up-down
Closed

Add the Feature of Reordering Shopping List by Moving Up or Down an Item#41565
ShaneQi wants to merge 2 commits intohome-assistant:devfrom
ShaneQi:feature/shopping-list-move-up-down

Conversation

@ShaneQi
Copy link
Copy Markdown
Contributor

@ShaneQi ShaneQi commented Oct 9, 2020

Proposed change

Adding the feature of recording shopping list (the shopping list component) by adding the api and ws endpoints to move up or move down a shopping list item.

The Frontend PR: home-assistant/frontend#7281

Kapture 2020-10-09 at 12 04 17

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [N/A] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [N/A] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [N/A] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@ShaneQi
Copy link
Copy Markdown
Contributor Author

ShaneQi commented Oct 9, 2020

I'm going to close this PR and work on supporting drag & drop as we discussed in home-assistant/frontend#7281.

The prototype:

Kapture 2020-10-09 at 16 39 06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants