Skip to content

Remove unnecessary instance attribute in Plex reauth config flow#41000

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
jjlawren:plex_simpler_entry_lookup
Oct 1, 2020
Merged

Remove unnecessary instance attribute in Plex reauth config flow#41000
MartinHjelmare merged 2 commits intohome-assistant:devfrom
jjlawren:plex_simpler_entry_lookup

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Oct 1, 2020

Proposed change

No need to store the entry_id during a reauth flow as we can easily obtain the entry itself while setting the unique ID.

Based on feedback in #40469.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Comment thread homeassistant/components/plex/config_flow.py
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit b3464c5 into home-assistant:dev Oct 1, 2020
@jjlawren jjlawren deleted the plex_simpler_entry_lookup branch October 1, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants