Remove unnecessary instance attribute in Plex reauth config flow#41000
Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom Oct 1, 2020
Merged
Remove unnecessary instance attribute in Plex reauth config flow#41000MartinHjelmare merged 2 commits intohome-assistant:devfrom
MartinHjelmare merged 2 commits intohome-assistant:devfrom
Conversation
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
No need to store the
entry_idduring a reauth flow as we can easily obtain the entry itself while setting the unique ID.Based on feedback in #40469.
Type of change
Additional information
Checklist
black --fast homeassistant tests)The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: