Add support to reauthorize expired Plex tokens#40469
Merged
Merged
Conversation
jjlawren
force-pushed
the
plex_reauthorize_flow
branch
from
ac8971f to
e01bbe3
Compare
balloob
approved these changes
Sep 28, 2020
| self.context[CONF_SOURCE] # pylint: disable=no-member | ||
| == config_entries.SOURCE_REAUTH | ||
| ): | ||
| entry = self.hass.config_entries.async_get_entry(self._entry_id) |
Member
There was a problem hiding this comment.
Setting the unique id for an existing entry will return that entry. Looks like we can simplify this and not store the entry id.
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The integration currently needs to be removed and recreated if an authentication token expires. This detects an expired token and begins a config flow to reauthorize while preserving entities/options/etc.
If an expired token is detected during runtime, the integration will reload itself to avoid continuous logging errors and trigger the reauth step.
Currently does not handle reauthorizing in advanced mode as the reauth flow is created by the backend while that flag is set by the frontend.
Example reconfiguration alert from Integrations page:
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: