Skip to content

Implement template scan_interval directive#40686

Closed
bdraco wants to merge 27 commits intohome-assistant:devfrom
bdraco:template_scan_interval
Closed

Implement template scan_interval directive#40686
bdraco wants to merge 27 commits intohome-assistant:devfrom
bdraco:template_scan_interval

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Sep 27, 2020

Needs #40685

Proposed change

Implement template scan_interval directive from home-assistant/architecture#206

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Sep 27, 2020

  • template tests
  • event tests
  • docs

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Sep 27, 2020

def _refresh is getting a bit too long so I'd like to refactor it

for track_template_ in self._track_templates:
    rendered, update = self._render_template_if_ready(
        track_template_,
        event,
        now
    )

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Sep 27, 2020

Also needs to skip updates if there is an event and we have an interval listener for the template so we don't trigger on entities from other templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants