Skip to content

Remove unneeded last_info from _TrackTemplateResultInfo#40685

Closed
bdraco wants to merge 24 commits intohome-assistant:devfrom
bdraco:drop_last_info_after_ratelimit_refactor
Closed

Remove unneeded last_info from _TrackTemplateResultInfo#40685
bdraco wants to merge 24 commits intohome-assistant:devfrom
bdraco:drop_last_info_after_ratelimit_refactor

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Sep 27, 2020

Proposed change

Remove unneeded last_info from _TrackTemplateResultInfo

After the refactoring in #40667 this is no
longer needed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco mentioned this pull request Sep 27, 2020
21 tasks
@bdraco bdraco force-pushed the drop_last_info_after_ratelimit_refactor branch from 96ee82e to ad3e9c5 Compare September 27, 2020 23:12
@bdraco bdraco force-pushed the drop_last_info_after_ratelimit_refactor branch from ad3e9c5 to b3010c0 Compare September 28, 2020 13:45
@bdraco
Copy link
Member Author

bdraco commented Sep 28, 2020

Superseded by #40737

@bdraco bdraco closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants