Skip to content

Fix camera play stream#40641

Merged
balloob merged 11 commits intohome-assistant:devfrom
hunterjm:fix-camera-play-stream
Sep 28, 2020
Merged

Fix camera play stream#40641
balloob merged 11 commits intohome-assistant:devfrom
hunterjm:fix-camera-play-stream

Conversation

@hunterjm
Copy link
Copy Markdown
Member

@hunterjm hunterjm commented Sep 26, 2020

Proposed change

This PR allows passing additional data into pychromecast in order to allow casting cameras from Home Assistant after we changed from MPEG-TS segments to fragmented MP4 segments in 0.115. Needed to also bump pychromecast to 7.5.0 to expose the required features.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @uvjustin, mind taking a look at this pull request as its been labeled with an integration (stream) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@hunterjm hunterjm added this to the 0.115.4 milestone Sep 26, 2020
@probot-home-assistant
Copy link
Copy Markdown

Hey there @emontnemery, mind taking a look at this pull request as its been labeled with an integration (cast) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@hunterjm hunterjm force-pushed the fix-camera-play-stream branch from de04e06 to 3165b06 Compare September 27, 2020 16:47
@hunterjm hunterjm marked this pull request as ready for review September 27, 2020 16:48
@hunterjm hunterjm force-pushed the fix-camera-play-stream branch from 3165b06 to a8c8513 Compare September 27, 2020 21:02
@balloob balloob merged commit 8bc62f3 into home-assistant:dev Sep 28, 2020
balloob pushed a commit that referenced this pull request Sep 28, 2020
Co-authored-by: Justin Wong <46082645+uvjustin@users.noreply.github.com>
@balloob balloob mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streaming camera to Google Home is broken in 0.115

5 participants