Allow passing additional media information through to play_media#420
Merged
emontnemery merged 1 commit intohome-assistant-libs:masterfrom Sep 27, 2020
Merged
Conversation
21 tasks
emontnemery
approved these changes
Sep 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Home Assistant 0.115 we changed the format of the HLS stream used for showing cameras from MPEG-TS to Fragmented MP4. In order to have chromecast play fmp4 files, we need to forward the
hlsVideoSegmentFormatoption to the device. Since there are additional MediaInformation options, I implemented this in a way to allow other options to also be utilized. See https://developers.google.com/cast/docs/reference/web_receiver/cast.framework.messages.MediaInformation