Skip to content

Fix fitbit current URL not available while configuring #40547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 4 commits into from
Sep 27, 2020
Merged

Fix fitbit current URL not available while configuring #40547

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
742439b
Fixes #40517 - current URL isn't available while configuring
colinfrei Sep 24, 2020
38f8f70
fix black
colinfrei Sep 24, 2020
f1c80bc
Apply suggestions from code review
balloob Sep 27, 2020
a16e2a5
Black
balloob Sep 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions homeassistant/components/fitbit/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,7 @@ def fitbit_configuration_callback(callback_data):
else:
setup_platform(hass, config, add_entities, discovery_info)

start_url = (
f"{get_url(hass, require_current_request=True)}{FITBIT_AUTH_CALLBACK_PATH}"
)
start_url = f"{get_url(hass)}{FITBIT_AUTH_CALLBACK_PATH}"

description = f"""Please create a Fitbit developer app at
https://dev.fitbit.com/apps/new.
Expand Down Expand Up @@ -222,7 +220,7 @@ def request_oauth_completion(hass):
def fitbit_configuration_callback(callback_data):
"""Handle configuration updates."""

start_url = f"{get_url(hass, require_current_request=True)}{FITBIT_AUTH_START}"
start_url = f"{get_url(hass)}{FITBIT_AUTH_START}"

description = f"Please authorize Fitbit by visiting {start_url}"

Expand Down Expand Up @@ -314,9 +312,7 @@ def setup_platform(hass, config, add_entities, discovery_info=None):
config_file.get(CONF_CLIENT_ID), config_file.get(CONF_CLIENT_SECRET)
)

redirect_uri = (
f"{get_url(hass, require_current_request=True)}{FITBIT_AUTH_CALLBACK_PATH}"
)
redirect_uri = f"{get_url(hass)}{FITBIT_AUTH_CALLBACK_PATH}"

fitbit_auth_start_url, _ = oauth.authorize_token_url(
redirect_uri=redirect_uri,
Expand Down