Skip to content

Fix fitbit current URL not available while configuring#40547

Merged
balloob merged 4 commits intohome-assistant:devfrom
colinfrei:patch-3
Sep 27, 2020
Merged

Fix fitbit current URL not available while configuring#40547
balloob merged 4 commits intohome-assistant:devfrom
colinfrei:patch-3

Conversation

@colinfrei
Copy link
Copy Markdown
Contributor

@colinfrei colinfrei commented Sep 24, 2020

Proposed change

Switch to using prefer_external over require_current_request, since the config setup doesn't seem to have the request context yet.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
sensor:
  - platform: fitbit
    clock_format: 12H
    unit_system: 'en_US'
    monitored_resources:
      - 'body/weight'
      - 'devices/battery'
      - 'activities/steps'
      - 'sleep/minutesAsleep'

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title Fixes #40517 - current URL isn't available while configuring Fix fitbit current URL isn't available while configuring Sep 24, 2020
@MartinHjelmare MartinHjelmare changed the title Fix fitbit current URL isn't available while configuring Fix fitbit current URL not available while configuring Sep 24, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, this makes sense. This integration really needs to get rid of the old configurator.

Let's make sure we raise an issue for that 👍

@frenck frenck added this to the 0.115.3 milestone Sep 25, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little mind change

@frenck frenck modified the milestones: 0.115.3, 0.115.4 Sep 25, 2020
balloob and others added 2 commits September 27, 2020 22:26
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@balloob balloob merged commit 13b6fe2 into home-assistant:dev Sep 27, 2020
balloob added a commit that referenced this pull request Sep 28, 2020
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@balloob balloob mentioned this pull request Sep 28, 2020
Bre77 pushed a commit to Bre77/core that referenced this pull request Sep 30, 2020
…t#40547)

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Bre77 pushed a commit to Bre77/core that referenced this pull request Oct 1, 2020
…t#40547)

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fitbit component not starting

4 participants