Fix fitbit current URL not available while configuring#40547
Merged
balloob merged 4 commits intohome-assistant:devfrom Sep 27, 2020
Merged
Fix fitbit current URL not available while configuring#40547balloob merged 4 commits intohome-assistant:devfrom
balloob merged 4 commits intohome-assistant:devfrom
Conversation
frenck
approved these changes
Sep 25, 2020
Member
frenck
left a comment
There was a problem hiding this comment.
Meh, this makes sense. This integration really needs to get rid of the old configurator.
Let's make sure we raise an issue for that 👍
balloob
approved these changes
Sep 27, 2020
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
balloob
added a commit
that referenced
this pull request
Sep 28, 2020
Co-authored-by: Franck Nijhof <frenck@frenck.nl> Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Merged
Bre77
pushed a commit
to Bre77/core
that referenced
this pull request
Sep 30, 2020
…t#40547) Co-authored-by: Franck Nijhof <frenck@frenck.nl> Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Bre77
pushed a commit
to Bre77/core
that referenced
this pull request
Oct 1, 2020
…t#40547) Co-authored-by: Franck Nijhof <frenck@frenck.nl> Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Switch to using prefer_external over require_current_request, since the config setup doesn't seem to have the request context yet.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: