Skip to content

Local media source: return different error if media folder doesnt exist #39759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 4 commits into from
Sep 7, 2020
Merged

Local media source: return different error if media folder doesnt exist #39759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8203f8
Local media source: return different error if media folder doesnt exist
bramkragten Sep 7, 2020
5462092
Oops...
bramkragten Sep 7, 2020
9f645cd
Restore media_player.py
bramkragten Sep 7, 2020
7f632e6
pylint
bramkragten Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions homeassistant/components/media_source/local_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ def _browse_media(self, source_dir_id, location):
full_path = Path(self.hass.config.path("media", location))

if not full_path.exists():
if location == "":
raise BrowseError("Media directory does not exist.")
raise BrowseError("Path does not exist.")

if not full_path.is_dir():
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/spotify/media_player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ def library_payload():
{"name": item["name"], "type": item["type"], "uri": item["type"]}
)
)
return library_info
return BrowseMedia(**library_info)
Copy link
Copy Markdown
Member

@balloob balloob Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we already have a PR for this ?

Copy link
Copy Markdown
Member Author

@bramkragten bramkragten Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, merged and all... I reverted it but it stays... 🤷‍♂️ Git...



def fetch_image_url(item, key="images"):
Expand Down