Local media source: return different error if media folder doesnt exist#39759
Merged
bramkragten merged 4 commits intodevfrom Sep 7, 2020
Merged
Local media source: return different error if media folder doesnt exist#39759bramkragten merged 4 commits intodevfrom
bramkragten merged 4 commits intodevfrom
Conversation
probot-home-assistant
bot
added
integration: media_source
integration: spotify
small-pr
balloob
approved these changes
Sep 7, 2020
9 tasks
balloob
reviewed
Sep 7, 2020
| ) | ||
| ) | ||
| return library_info | ||
| return BrowseMedia(**library_info) |
Member
There was a problem hiding this comment.
Don't we already have a PR for this ?
Member
Author
There was a problem hiding this comment.
Yeah, merged and all... I reverted it but it stays... 🤷♂️ Git...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Show different error for when the
mediadirectory is missing, so we can show a message on the frontend.Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: