Skip to content

Increase slow setup logging to warning level#37635

Merged
frenck merged 1 commit intohome-assistant:devfrom
bdraco:slow_setup_never_seen
Jul 8, 2020
Merged

Increase slow setup logging to warning level#37635
frenck merged 1 commit intohome-assistant:devfrom
bdraco:slow_setup_never_seen

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jul 7, 2020

Proposed change

On discord, users were having trouble figuring out
why Home Assistant was stuck in the startup
phase. I thought this was a solved problem.

When I fixed verbose logging in #36444, I did not
realize this would mean almost nobody would
see the log messages about which integration
was slow to setup / blocking startup.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

When I fixed verbose logging in home-assistant#36444, I did not
realize this would mean almost nobody would
see this now.
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, yeah that will help 👍

@frenck frenck merged commit 4343e84 into home-assistant:dev Jul 8, 2020
balloob pushed a commit that referenced this pull request Jul 9, 2020
When I fixed verbose logging in #36444, I did not
realize this would mean almost nobody would
see this now.
@balloob balloob mentioned this pull request Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

4 participants