Skip to content

Ensure verbose logging flag is respected.#36444

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:logger_level
Jun 4, 2020
Merged

Ensure verbose logging flag is respected.#36444
balloob merged 1 commit intohome-assistant:devfrom
bdraco:logger_level

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 4, 2020 •
edited
Loading

Proposed change

Fixes: Logger Levels Initially Ignored

Regression from #35633. Verified changes do not regress #35749

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added core small-pr PRs with less than 30 lines. labels Jun 4, 2020
@bdraco bdraco mentioned this pull request Jun 4, 2020
Closed
@bdraco bdraco added this to the 0.111.0 milestone Jun 4, 2020
@balloob balloob merged commit 36b157b into home-assistant:dev Jun 4, 2020
balloob pushed a commit that referenced this pull request Jun 4, 2020
@bdraco @balloob
Ensure verbose logging flag is respected. (#36444)
1b5a601
bdraco added a commit to bdraco/home-assistant that referenced this pull request Jul 7, 2020
@bdraco
Increase slow setup logging to warning level
97ef716 
When I fixed verbose logging in home-assistant#36444, I did not
realize this would mean almost nobody would
see this now.
@bdraco bdraco mentioned this pull request Jul 7, 2020
Merged
20 tasks
frenck pushed a commit that referenced this pull request Jul 8, 2020
@bdraco
Increase slow setup logging to warning level (#37635)
4343e84 
When I fixed verbose logging in #36444, I did not
realize this would mean almost nobody would
see this now.
balloob pushed a commit that referenced this pull request Jul 9, 2020
@bdraco @balloob
Increase slow setup logging to warning level (#37635)
9be06d8 
When I fixed verbose logging in #36444, I did not
realize this would mean almost nobody would
see this now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cherry-picked cla-signed core small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.111.0

Development

Successfully merging this pull request may close these issues.

0.111.0b0 Logger Levels Initially Ignored

3 participants

@bdraco @balloob @homeassistant