Skip to content

Fix Plugwise zeroconf discovery formatting#37457

Merged
frenck merged 1 commit intohome-assistant:devfrom
plugwise:plugwise-blackfix
Jul 4, 2020
Merged

Fix Plugwise zeroconf discovery formatting#37457
frenck merged 1 commit intohome-assistant:devfrom
plugwise:plugwise-blackfix

Conversation

@CoMPaTech
Copy link
Copy Markdown
Member

Proposed change

Fix black formatting that was not detected from #37289

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bouwew, mind taking a look at this pull request as its been labeled with an integration (plugwise) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@CoMPaTech CoMPaTech mentioned this pull request Jul 4, 2020
20 tasks
Copy link
Copy Markdown
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, as fellow code-owner.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CoMPaTech!

Black won't detect this indeed. 👍

@frenck frenck merged commit 0b11fda into home-assistant:dev Jul 4, 2020
@CoMPaTech
Copy link
Copy Markdown
Member Author

Thanks, @CoMPaTech!

Black won't detect this indeed. 👍

Luckily we have @MartinHjelmare :)

@CoMPaTech CoMPaTech deleted the plugwise-blackfix branch October 8, 2020 17:51
hahn-th pushed a commit to hahn-th/core that referenced this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants