Add Plugwise zeroconf discovery#37289
Conversation
probot-home-assistant
Bot
added
code-quality
has-tests
integration: plugwise
new-feature
labels
|
Hey there @CoMPaTech, mind taking a look at this pull request as its been labeled with an integration ( |
|
Please remove the coverage file. |
|
Not sure why it was even there, removed it :) |
MartinHjelmare
changed the title
|
@balloob, @MartinHjelmare |
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
|
|
||
| _product = _properties.get("product", None) | ||
| _version = _properties.get("version", "n/a") | ||
| _name = f"{ZEROCONF_MAP.get(_product,_product)} v{_version}" |
There was a problem hiding this comment.
There's a missing space after the comma. Didn't CI black catch this?
There was a problem hiding this comment.
Apparently neither did pre-commit then ... let me check
There was a problem hiding this comment.
I guess because it's inside the format that it doesn't trigger ... running black manually with/without space doesn't yield different results
There was a problem hiding this comment.
I'll quickly rescan as well, but opened #37457 in the meantime
5 participants
Proposed change
Detect the Plugwise Smile(s) in your network automatically, only needed to insert the passcode to configure an integration.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: