Update plugwise to async and config_flow sensor part#36219
Update plugwise to async and config_flow sensor part#36219MartinHjelmare merged 39 commits intohome-assistant:devfrom
Conversation
|
Hey there @laetificat, @bouwew, mind taking a look at this pull request as its been labeled with a integration ( |
|
My review-comments, provided via Discord, have been included in the code. |
2a2ac71 to
03a274c
Compare
|
As indicated in the parent PR - the baseclass took some time and just committed as progress. Will check for further issues and self-review in the morning. |
606cd88 to
c793098
Compare
|
Constants have been adjusted further, we moved the Sensor-childclass, but we'll re-use this on As discussed, working on test - but that will be a better fit in a different PR. |
|
There is some more cleanup that can be done to get rid of the return None in the base class. However given the size of this PR and beta coming up, let’s keep the scope contained as additional cleanup can be done in a new PR when the tests are added. |
@bouwew noticed something wrong with the (actual) naming, so we cleaned that up just now. w.r.t. @MartinHjelmare 's comment on the parent PR - cleanup of translations still in this PR or also in a forthcoming one? |
bdraco
left a comment
There was a problem hiding this comment.
Much cleaner. Great work. 👍
Everything still working ?
|
Works on my setup and when I run the tests against it - @bouwew was still testing some final parts. |
|
As part of peer-review: added icon for non-device class auxiliary back in at request of @bouwew |
|
Icons are missing for sensors that do not have a DEVICE_CLASS. |
|
Note: if we only take |
|
@MartinHjelmare nothing needed to be done anymore for this #33691 (comment) right? |
|
No, not now. 👍 |
|
Ping here when we should merge. |
|
@MartinHjelmare from @CoMPaTech and me, yes, please merge. |
|
Test failure is unrelated. |
Breaking change
See #33691 as 'parent'-PR. This PR is the first of three 'child'-PRs for the parent. It adds the
sensorplatform for feature-compatibility with regard to the breaking changes of the parent PR for current 'Plugwise Anna' climate devices.Proposed change
Provide for sensors for both climate and non-climate Plugwise components. Moving some attributes (i.e. outdoor_temperature) to sensor as indicated on previous PRs by reviewers.
This PR is awaiting the parent PR to be merged for changes to
__init__.py(hence the patchfile).Type of change
Additional information
This PR accompanies #33691 to provide comparible functionality for climate devices (i.e.
climateandsensor). Addition of thissensorPR also allows DSMR devices. Two more child PRs are following forbinary_sensor(also for climate setups) andswitch(for power-controle within climate).Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following [Integration Quality Scale][quality-scale]: