Skip to content

Fix roku select source with app ids #36191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 7 commits into from
May 27, 2020
Merged

Fix roku select source with app ids #36191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2145d3e
fix roku select source with app ids
ctalkington May 27, 2020
7d6e40d
Update test_media_player.py
ctalkington May 27, 2020
4506e53
Update test_media_player.py
ctalkington May 27, 2020
860c337
Update test_media_player.py
ctalkington May 27, 2020
1f5faef
Update test_media_player.py
ctalkington May 27, 2020
dea7369
Update media_player.py
ctalkington May 27, 2020
9e8a883
Update media_player.py
ctalkington May 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion homeassistant/components/roku/media_player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,12 @@ async def async_select_source(self, source: str) -> None:
await self.coordinator.roku.remote("home")

appl = next(
(app for app in self.coordinator.data.apps if app.name == source), None
(
app
for app in self.coordinator.data.apps
if source in (app.name, app.app_id)
),
None,
)

if appl is not None:
Expand Down
14 changes: 12 additions & 2 deletions tests/components/roku/test_media_player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,15 +332,25 @@ async def test_services(

remote_mock.assert_called_once_with("home")

with patch("homeassistant.components.roku.Roku.launch") as remote_mock:
with patch("homeassistant.components.roku.Roku.launch") as launch_mock:
await hass.services.async_call(
MP_DOMAIN,
SERVICE_SELECT_SOURCE,
{ATTR_ENTITY_ID: MAIN_ENTITY_ID, ATTR_INPUT_SOURCE: "Netflix"},
blocking=True,
)

remote_mock.assert_called_once_with("12")
launch_mock.assert_called_once_with("12")

with patch("homeassistant.components.roku.Roku.launch") as launch_mock:
await hass.services.async_call(
MP_DOMAIN,
SERVICE_SELECT_SOURCE,
{ATTR_ENTITY_ID: MAIN_ENTITY_ID, ATTR_INPUT_SOURCE: 12},
blocking=True,
)

launch_mock.assert_called_once_with("12")


async def test_tv_services(
Expand Down