Skip to content

Fix roku select source with app ids#36191

Merged
MartinHjelmare merged 7 commits intodevfrom
ctalkington-roku-source
May 27, 2020
Merged

Fix roku select source with app ids#36191
MartinHjelmare merged 7 commits intodevfrom
ctalkington-roku-source

Conversation

@ctalkington
Copy link
Copy Markdown
Contributor

@ctalkington ctalkington commented May 27, 2020

Breaking change

Proposed change

It was previously possible to pass an app id to select_source service due to the old library internal lookups.

This change restores that ability.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@ctalkington ctalkington added this to the 0.110.4 milestone May 27, 2020
@MartinHjelmare MartinHjelmare merged commit 6fbc3b5 into dev May 27, 2020
@MartinHjelmare MartinHjelmare deleted the ctalkington-roku-source branch May 27, 2020 15:53
balloob pushed a commit that referenced this pull request May 28, 2020
@balloob balloob mentioned this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roku media_player.select_source does not switch to specified app

4 participants