Skip to content

Fix client ID lookup for official apps #36131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgarwood merged 1 commit into from
May 25, 2020
Merged

Fix client ID lookup for official apps #36131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions homeassistant/components/auth/indieauth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ async def verify_redirect_uri(hass, client_id, redirect_uri):
# Whitelist the iOS and Android callbacks so that people can link apps
# without being connected to the internet.
if redirect_uri == "homeassistant://auth-callback" and client_id in (
"https://www.home-assistant.io/android",
"https://www.home-assistant.io/iOS",
"https://home-assistant.io/android",
"https://home-assistant.io/iOS",
):
return True

Expand Down
3 changes: 1 addition & 2 deletions tests/components/auth/test_indieauth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,7 @@ async def test_find_link_tag_max_size(hass, mock_session):


@pytest.mark.parametrize(
"client_id",
["https://www.home-assistant.io/android", "https://www.home-assistant.io/iOS"],
"client_id", ["https://home-assistant.io/android", "https://home-assistant.io/iOS"],
)
async def test_verify_redirect_uri_android_ios(client_id):
"""Test that we verify redirect uri correctly for Android/iOS."""
Expand Down