Skip to content

Fix client ID lookup for official apps#36131

Merged
cgarwood merged 1 commit intodevfrom
fix-apps-lookup
May 25, 2020
Merged

Fix client ID lookup for official apps#36131
cgarwood merged 1 commit intodevfrom
fix-apps-lookup

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 25, 2020

Breaking change

Proposed change

We hardcode the client IDs of the official Android and iOS app so people can authenticate without having their Home Assistant instance require internet to validate the custom callback.

Except that we hardcoded the wrong client IDs 😬

This PR fixes it.

iOS client ID:

https://github.com/home-assistant/iOS/blob/master/HomeAssistant/Authentication/AuthenticationController.swift#L43

Android client ID:

https://github.com/home-assistant/android/blob/f42ab8fa98760924fee63bec86185113f44f333a/data/src/main/java/io/homeassistant/companion/android/data/authentication/AuthenticationService.kt#L11

Fixes home-assistant/android#601

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@dshokouhi
Copy link
Copy Markdown
Member

Should we add this to the next milestone? I suspect more users may hit that issue

@cgarwood cgarwood added this to the 0.110.3 milestone May 25, 2020
@cgarwood cgarwood merged commit ba120d4 into dev May 25, 2020
@delete-merged-branch delete-merged-branch Bot deleted the fix-apps-lookup branch May 25, 2020 19:39
frenck pushed a commit that referenced this pull request May 26, 2020
@frenck frenck mentioned this pull request May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android : Invalid client ID or redirect URI

5 participants