Skip to content

Fix opengarage async_setup_platform#36075

Merged
Danielhiversen merged 2 commits intodevfrom
open_garage_async_setup_platform
May 24, 2020
Merged

Fix opengarage async_setup_platform#36075
Danielhiversen merged 2 commits intodevfrom
open_garage_async_setup_platform

Conversation

@Danielhiversen
Copy link
Copy Markdown
Member

@Danielhiversen Danielhiversen commented May 24, 2020

Breaking change

Proposed change

opengarage async_setup_platform

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@Danielhiversen Danielhiversen added this to the 0.110.3 milestone May 24, 2020
@Danielhiversen Danielhiversen mentioned this pull request May 24, 2020
20 tasks
@MartinHjelmare MartinHjelmare changed the title opengarage async_setup_platform Fix opengarage async_setup_platform May 24, 2020
Comment thread homeassistant/components/opengarage/cover.py Outdated
@probot-home-assistant
Copy link
Copy Markdown

Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with a integration (opengarage) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Danielhiversen Danielhiversen merged commit 9212d1c into dev May 24, 2020
@delete-merged-branch delete-merged-branch Bot deleted the open_garage_async_setup_platform branch May 24, 2020 12:29
frenck pushed a commit that referenced this pull request May 26, 2020
* opengarage async_setup_platform

* async_add_entities
@frenck frenck mentioned this pull request May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenGarage Component Fails After Upgrading to 0.110.1

4 participants