Skip to content

Add Open garage unique_id#36074

Merged
MartinHjelmare merged 1 commit intodevfrom
opengarage_unique_id
May 24, 2020
Merged

Add Open garage unique_id#36074
MartinHjelmare merged 1 commit intodevfrom
opengarage_unique_id

Conversation

@Danielhiversen
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Open garage add unique_id

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Comment thread homeassistant/components/opengarage/cover.py Outdated
@probot-home-assistant
Copy link
Copy Markdown

Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with a integration (opengarage) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@Danielhiversen Danielhiversen force-pushed the opengarage_unique_id branch from c0791da to d7201df Compare May 24, 2020 12:32
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare changed the title Open garage add unique_id Add Open garage unique_id May 24, 2020
@MartinHjelmare MartinHjelmare merged commit ed7ac3c into dev May 24, 2020
@delete-merged-branch delete-merged-branch Bot deleted the opengarage_unique_id branch May 24, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants