Skip to content

Add ZHA roller shadows as cover instead of switch#36059

Merged
Adminiuga merged 4 commits intohome-assistant:devfrom
Adminiuga:ac/zha-cover-shade-2
May 24, 2020
Merged

Add ZHA roller shadows as cover instead of switch#36059
Adminiuga merged 4 commits intohome-assistant:devfrom
Adminiuga:ac/zha-cover-shade-2

Conversation

@Adminiuga
Copy link
Copy Markdown
Contributor

Breaking change

Yes: ZHA Roller shadows are implemented as On_Off/Level clusters in Zigbee so until now these devices would be presented as switch domain instead of cover. This PR changes, so those devices are presented correctly as cover devices.

Proposed change

Implement ZHA Shade devices as cover devices in HA. This device type includes roller shades, drapes, and tilt-only blinds

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

n/a

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@Adminiuga
Copy link
Copy Markdown
Contributor Author

@dmulcahey i'm tempted to make Keen vents as cover as well? probably in a different PR though

@Adminiuga
Copy link
Copy Markdown
Contributor Author

But it would need to revert zha.DeviceType.LEVEL_CONTROLLABLE_OUTPUT: 'light', which was added for Keen vents in #18161

@Adminiuga
Copy link
Copy Markdown
Contributor Author

in the device list, only Keen vents have device_type == 0x0003

@Adminiuga Adminiuga merged commit f4c5b9f into home-assistant:dev May 24, 2020
@bckthomas
Copy link
Copy Markdown

HI
Do you know when this commit will be merge in master branch ?
Thanks

@Adminiuga
Copy link
Copy Markdown
Contributor Author

master branch is for releases, so it is going to be in 0.111.x release. I think beta is next week, so release should be on jun 9th

@Adminiuga Adminiuga deleted the ac/zha-cover-shade-2 branch June 8, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZHA Rollershutters as switch instead of cover

5 participants