Skip to content

Add support for various load level devices#18161

Merged
fabaff merged 1 commit intohome-assistant:devfrom
rafale77:patch-2
Nov 3, 2018
Merged

Add support for various load level devices#18161
fabaff merged 1 commit intohome-assistant:devfrom
rafale77:patch-2

Conversation

@rafale77
Copy link
Copy Markdown
Contributor

@rafale77 rafale77 commented Nov 3, 2018

Description:

Adding support for LoadLevel device endpoint as a light device.
Example of support: Keen Smartvents.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Nov 3, 2018
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit f76ccb6 into home-assistant:dev Nov 3, 2018
@ghost ghost removed the in progress label Nov 3, 2018
@balloob balloob mentioned this pull request Nov 29, 2018
@rafale77 rafale77 deleted the patch-2 branch December 2, 2018 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed integration: zha small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants