Skip to content

Reset zeroconf log level to allow log level configuration#36002

Merged
bdraco merged 1 commit intohome-assistant:devfrom
emontnemery:zeroconf_log
May 23, 2020
Merged

Reset zeroconf log level to allow log level configuration#36002
bdraco merged 1 commit intohome-assistant:devfrom
emontnemery:zeroconf_log

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented May 22, 2020

Proposed change

Reset zeroconf log level to allow log level configuration.

Background:
Zeroconf sets log level to logging.WARN if it's set to logging.NOTSET, which makes it impossible to rely on the logger component to filter zeroconf logs less severe than WARN.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 22, 2020

@emontnemery I'll look at this as soon as I can actually see the files. Github keeps giving me 500 errors and pulls are failing.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 22, 2020

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 22, 2020

zeroconf does a massive amount of logging. Need to check to make sure this isn't going to be a problem for the log filter.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 22, 2020

Leaving the profiler running and will check it in a bit

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 22, 2020

This seems like its ok when coupled with the logger performance fixes in #35749 #35633 #35700 and the reduction of duplicate service browsers #35997.

Might be a performance issue for 0.110 since the log filtering is more expensive without #35749

@MartinHjelmare
Copy link
Copy Markdown
Member

Should we wait for the other PRs to be merged?

@emontnemery
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare Yes, sure, this PR can wait.

@bdraco bdraco merged commit b136390 into home-assistant:dev May 23, 2020
@emontnemery emontnemery deleted the zeroconf_log branch June 10, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants