Reset zeroconf log level to allow log level configuration#36002
Merged
bdraco merged 1 commit intohome-assistant:devfrom May 23, 2020
Merged
Reset zeroconf log level to allow log level configuration#36002bdraco merged 1 commit intohome-assistant:devfrom
bdraco merged 1 commit intohome-assistant:devfrom
Conversation
Member
|
@emontnemery I'll look at this as soon as I can actually see the files. Github keeps giving me 500 errors and pulls are failing. |
Member
Member
|
zeroconf does a massive amount of logging. Need to check to make sure this isn't going to be a problem for the log filter. |
Member
|
Leaving the profiler running and will check it in a bit |
bdraco
approved these changes
May 22, 2020
Member
|
Should we wait for the other PRs to be merged? |
Contributor
Author
|
@MartinHjelmare Yes, sure, this PR can wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Reset zeroconf log level to allow log level configuration.
Background:
Zeroconf sets log level to
logging.WARNif it's set tologging.NOTSET, which makes it impossible to rely on the logger component to filter zeroconf logs less severe than WARN.Type of change
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: