Skip to content

Fix iaqualink sensors #36000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 2 commits into from
May 23, 2020
Merged

Fix iaqualink sensors #36000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8e66cd
iaqualink: small sensor fixes
flz May 22, 2020
7803018
Re-add device_class, fix type hints.
flz May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions homeassistant/components/iaqualink/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,25 @@ def name(self) -> str:
return self.dev.label

@property
def unit_of_measurement(self) -> str:
def unit_of_measurement(self) -> Optional[str]:
"""Return the measurement unit for the sensor."""
if self.dev.system.temp_unit == "F":
return TEMP_FAHRENHEIT
return TEMP_CELSIUS
if self.dev.name.endswith("_temp"):
if self.dev.system.temp_unit == "F":
return TEMP_FAHRENHEIT
return TEMP_CELSIUS
return None

Comment thread
flz marked this conversation as resolved.
@property
def state(self) -> str:
def state(self) -> Optional[str]:
"""Return the state of the sensor."""
return int(self.dev.state) if self.dev.state != "" else None
if self.dev.state == "":
return None

try:
state = int(self.dev.state)
except ValueError:
state = float(self.dev.state)
return state

@property
def device_class(self) -> Optional[str]:
Comment thread
flz marked this conversation as resolved.
Expand Down