Skip to content

Fix iaqualink sensors#36000

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
flz:iaqualink-fixes
May 23, 2020
Merged

Fix iaqualink sensors#36000
MartinHjelmare merged 2 commits intohome-assistant:devfrom
flz:iaqualink-fixes

Conversation

@flz
Copy link
Copy Markdown
Contributor

@flz flz commented May 22, 2020

Proposed change

Fixes two issues with sensors:

  • adds support for float-value sensors (causing exceptions at the moment)
  • prevents all sensors from being classified as temperature sensors

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes part of error iaqualink #30078
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@MartinHjelmare MartinHjelmare changed the title iaqualink: small sensor fixes Fix iaqualink sensors May 22, 2020
Comment thread homeassistant/components/iaqualink/sensor.py
Comment thread homeassistant/components/iaqualink/sensor.py
@MartinHjelmare
Copy link
Copy Markdown
Member

Thanks!

@MartinHjelmare MartinHjelmare merged commit 8b8aa19 into home-assistant:dev May 23, 2020
@flz flz deleted the iaqualink-fixes branch May 23, 2020 16:20
@flz
Copy link
Copy Markdown
Contributor Author

flz commented May 25, 2020

@MartinHjelmare Any chance this could make it in the next patch release?

@MartinHjelmare MartinHjelmare added this to the 0.110.3 milestone May 25, 2020
@MartinHjelmare
Copy link
Copy Markdown
Member

Ok.

frenck pushed a commit that referenced this pull request May 26, 2020
* iaqualink: small sensor fixes

* Re-add device_class, fix type hints.
@frenck frenck mentioned this pull request May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants