Skip to content

Fix zeroconf race condition that takes down the service#35996

Closed
bdraco wants to merge 1 commit intohome-assistant:devfrom
bdraco:zeroconf_race_crash
Closed

Fix zeroconf race condition that takes down the service#35996
bdraco wants to merge 1 commit intohome-assistant:devfrom
bdraco:zeroconf_race_crash

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 22, 2020

Proposed change

Upstream changes
Race Fix: python-zeroconf/python-zeroconf@24a0619
Service Browsers: python-zeroconf/python-zeroconf@a6ad100

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco bdraco linked an issue May 22, 2020 that may be closed by this pull request
@bdraco bdraco added this to the 0.110.2 milestone May 22, 2020
Copy link
Copy Markdown
Contributor

@ctalkington ctalkington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending tests passing

@bdraco bdraco added dependency-bump Pull requests that update a dependency file bugfix labels May 22, 2020
@bdraco bdraco changed the title Fix zeroconf that takes down the service Fix zeroconf race condition that takes down the service May 22, 2020
@ctalkington
Copy link
Copy Markdown
Contributor

/AzurePipelines Run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 22, 2020

Github is having issues
fatal: could not read Username for 'https://github.com': terminal prompts disabled

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 23, 2020

/AzurePipelines Run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 23, 2020

Maybe github is working now ?

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 23, 2020

#35997 needs to go in first

@bdraco bdraco removed this from the 0.110.2 milestone May 23, 2020
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 23, 2020

This should probably wait until 0.111 as it’s not a regression even if it’s though it’s a high impact bug as the other changes in upstream should soak for a bit

@MartinHjelmare
Copy link
Copy Markdown
Member

Is this PR still needed if #35997 is merged? It seems that PR already has the library bump.

@frenck
Copy link
Copy Markdown
Member

frenck commented May 23, 2020

@MartinHjelmare I would say this one is viable for a patch release, while the referenced PR is a bigger change that is not viable for a patch release.

It does address a problem some in our community are currently experiencing.

Nevermind :) Now I had coffee, I see that it depends on it.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 23, 2020

Is this PR still needed if #35997 is merged? It seems that PR already has the library bump.

No longer needed.

I'll merge the details into #35997 so the changelog reflects the fix and close this one.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 23, 2020

Superseded by #35997

@bdraco bdraco closed this May 23, 2020
@bouwew bouwew mentioned this pull request Nov 26, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix cla-signed dependency-bump Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zeroconf: Exception during startup

5 participants