Skip to content

Ensure homekit functions if numpy is unavailable#35931

Merged
frenck merged 1 commit intohome-assistant:devfrom
bdraco:homekit_handle_broken_numpy
May 23, 2020
Merged

Ensure homekit functions if numpy is unavailable#35931
frenck merged 1 commit intohome-assistant:devfrom
bdraco:homekit_handle_broken_numpy

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 21, 2020

Proposed change

Defer importing TurboJPEG until we need it as it
imports numpy which may not be functional.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Defer importing TurboJPEG until we need it as it
imports numpy which may not be functional.
@frenck frenck merged commit 80de233 into home-assistant:dev May 23, 2020
@frenck frenck mentioned this pull request May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homekit not work after 0.110.0

3 participants