Skip to content

Add support for Daikin options to set temperature by 0.5 steps#35771

Closed
fredrike wants to merge 1 commit into
home-assistant:devfrom
fredrike:daikin-config
Closed

Add support for Daikin options to set temperature by 0.5 steps#35771
fredrike wants to merge 1 commit into
home-assistant:devfrom
fredrike:daikin-config

Conversation

@fredrike
Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

Some (but not all) Daikin units supports Target Temp in 0.5 steps, this adds an option for setting that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@fredrike fredrike changed the title Add support for Daikin config to set temperature by 0.5 steps Add support for Daikin options to set temperature by 0.5 steps May 18, 2020
@fredrike fredrike marked this pull request as ready for review May 18, 2020 17:30
@fredrike fredrike force-pushed the daikin-config branch 2 times, most recently from 02801cf to 14699a0 Compare May 29, 2020 06:45
@stale
Copy link
Copy Markdown

stale Bot commented Jul 3, 2020

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale Bot added the stale label Jul 3, 2020
@stale stale Bot closed this Jul 11, 2020
@stale stale Bot removed the stale label Jul 13, 2020
@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 13, 2020

@fredrike This PR has some merge conflicts. Could you resolve those?

@fredrike
Copy link
Copy Markdown
Contributor Author

I was under the impression that this shouldn't be merged..

#35414 (comment)

@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 13, 2020

Aah right, lets close it up until that discussion has been resolved 👍

@frenck frenck closed this Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support steps of 0.5 for Daikin AC

4 participants