Add config options to Daikin and add support for Daikin zeroconf discovery#35507
Add config options to Daikin and add support for Daikin zeroconf discovery#35507fredrike wants to merge 8 commits into
Conversation
c813f46 to
307b327
Compare
|
Too much is going on in this PR to be considered as a fix for 0.110.0. We want to avoid including breaking changes after the beta cut. Please split this PR up into one fix or change per PR. A small fix can more easily be tagged for beta. |
|
There are no breaking changes in this code. I worked really hard to have this pr up before the beta cut and I understand that it is not possible to review everything before beta cuts. I can of course break it in smaller parts but it would require quite some time as it also would mean rewriteing the test parts. Which parts do you want me to break out? The changes in discovery are essential as the previous code automatically created entities (which are not allowed according to documentation). |
|
Deprecating yaml counts as a breaking change. We'll tag it as a breaking change both when adding the warning and when the deprecation expires. Please do one PR per bullet:
|
|
@MartinHjelmare I've marked #35769 and #35771 as draft as they need rebase after the other two have been merged. But you say that it's only #35769 that is going to make 0.110? |
|
Only #35767 will make the beta since that's a fix. The others are not fixes. |
Description:
Multiple fixes in one PR.
Related issue (if applicable): fixes #35414, #34551, #35715
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#13199
Example entry for
configuration.yaml(if applicable):--yaml is deprecated 😄
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirementsin the manifest (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: