Skip to content

Add config options to Daikin and add support for Daikin zeroconf discovery#35507

Closed
fredrike wants to merge 8 commits into
home-assistant:devfrom
fredrike:daikin-configOption
Closed

Add config options to Daikin and add support for Daikin zeroconf discovery#35507
fredrike wants to merge 8 commits into
home-assistant:devfrom
fredrike:daikin-configOption

Conversation

@fredrike
Copy link
Copy Markdown
Contributor

@fredrike fredrike commented May 11, 2020

Description:

Multiple fixes in one PR.

  • Some (but not all) Daikin units supports Target Temp in 0.5 steps, this adds an option for setting that.
  • Deprecated yaml support (just warning).
  • Add support for zeroconf of some Daikin units.

Related issue (if applicable): fixes #35414, #34551, #35715

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#13199

Example entry for configuration.yaml (if applicable):

--yaml is deprecated 😄

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
    • I don't think that is applicable anymore.
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
    • I'm not sure if we need to test options..

@fredrike fredrike changed the title Add config options to Daikin Add config options to Daikin, add support for zeroconf discovery May 12, 2020
@fredrike fredrike changed the title Add config options to Daikin, add support for zeroconf discovery Add config options to Daikin and add support for Daikin zeroconf discovery May 12, 2020
@fredrike fredrike force-pushed the daikin-configOption branch from c813f46 to 307b327 Compare May 17, 2020 14:25
@MartinHjelmare
Copy link
Copy Markdown
Member

Too much is going on in this PR to be considered as a fix for 0.110.0. We want to avoid including breaking changes after the beta cut.

Please split this PR up into one fix or change per PR. A small fix can more easily be tagged for beta.

@fredrike
Copy link
Copy Markdown
Contributor Author

There are no breaking changes in this code.

I worked really hard to have this pr up before the beta cut and I understand that it is not possible to review everything before beta cuts. I can of course break it in smaller parts but it would require quite some time as it also would mean rewriteing the test parts.

Which parts do you want me to break out? The changes in discovery are essential as the previous code automatically created entities (which are not allowed according to documentation).

@MartinHjelmare
Copy link
Copy Markdown
Member

Deprecating yaml counts as a breaking change. We'll tag it as a breaking change both when adding the warning and when the deprecation expires.

Please do one PR per bullet:

  • Fix discovery flow. (this PR is the priority)
  • Deprecate config yaml.
  • Add zeroconf flow.
  • Add options flow.
  • Bump library (if it's not depending on any of the above)

@fredrike
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare I've marked #35769 and #35771 as draft as they need rebase after the other two have been merged. But you say that it's only #35769 that is going to make 0.110?

@MartinHjelmare
Copy link
Copy Markdown
Member

Only #35767 will make the beta since that's a fix. The others are not fixes.

@fredrike fredrike marked this pull request as draft May 18, 2020 17:30
@fredrike fredrike closed this May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support steps of 0.5 for Daikin AC

3 participants