Skip to content

Add email as common data string#35546

Merged
balloob merged 2 commits intodevfrom
add-common-string-email
May 12, 2020
Merged

Add email as common data string#35546
balloob merged 2 commits intodevfrom
add-common-string-email

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 12, 2020

Breaking change

Proposed change

Add email as a common data string to be used as references and update it where necessary.

Realized when reviewing #35529 that some places used username as key but meant email.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob merged commit befda9a into dev May 12, 2020
@balloob balloob deleted the add-common-string-email branch May 12, 2020 16:08
@balloob balloob mentioned this pull request May 12, 2020
44 tasks
@lock lock Bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants