Skip to content

Use config flow references for data#35529

Merged
balloob merged 4 commits intodevfrom
some-config-flow-references
May 12, 2020
Merged

Use config flow references for data#35529
balloob merged 4 commits intodevfrom
some-config-flow-references

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 12, 2020

Breaking change

Proposed change

Update as many data references in config flows to generic strings. Includes script so we can use it for error/abort later.

Part of Translations 2.0 #34264

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob force-pushed the some-config-flow-references branch from a1bec0f to 8a0ed7b Compare May 12, 2020 15:46
@balloob balloob marked this pull request as draft May 12, 2020 15:56
@balloob balloob mentioned this pull request May 12, 2020
20 tasks
@balloob balloob force-pushed the some-config-flow-references branch from 8a0ed7b to 52c761e Compare May 12, 2020 17:19
@balloob balloob marked this pull request as ready for review May 12, 2020 17:20
@balloob balloob mentioned this pull request May 12, 2020
44 tasks
@balloob balloob merged commit dd32324 into dev May 12, 2020
@balloob balloob deleted the some-config-flow-references branch May 12, 2020 17:50
@lock lock Bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants