Skip to content

Add influxdb path parameter#35089

Merged
Adminiuga merged 1 commit into
home-assistant:devfrom
pdcemulator:dev
May 3, 2020
Merged

Add influxdb path parameter#35089
Adminiuga merged 1 commit into
home-assistant:devfrom
pdcemulator:dev

Conversation

@pdcemulator
Copy link
Copy Markdown
Contributor

@pdcemulator pdcemulator commented May 2, 2020

Proposed change

My InfluxDB is running behind a reverse proxy, like https://myhost.mydomain.tld/influx.
To be able to access this db from HA, we have to add the new path parameter. The path parameter is already supported by the influxdb-python lib, which is used by this integration.

This is my first PR, so I hope I did everything right.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
influxdb:
  path: influx

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @pdcemulator,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @fabaff, mind taking a look at this pull request as its been labeled with a integration (influxdb) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title influxdb: add support for path parameter Add influxdb path parameter May 2, 2020
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Adminiuga Adminiuga merged commit f37f488 into home-assistant:dev May 3, 2020
@lock lock Bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants