Skip to content

Add support for Velux Gates #34774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 4 commits into from
May 23, 2020
Merged

Add support for Velux Gates #34774

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22ba7dc
Add support for Velux Gates
Apr 27, 2020
8e47faf
Comment expanded and listing sorted alphabetically.
Apr 27, 2020
fc717e9
Merge remote-tracking branch 'upstream/dev' into dev
May 1, 2020
6ae6378
Merge remote-tracking branch 'upstream/dev' into dev
May 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions homeassistant/components/velux/cover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Support for Velux covers."""
from pyvlx import OpeningDevice, Position
from pyvlx.opening_device import Awning, Blind, GarageDoor, RollerShutter, Window
from pyvlx.opening_device import Awning, Blind, GarageDoor, Gate, RollerShutter, Window

from homeassistant.components.cover import (
ATTR_POSITION,
Expand Down Expand Up @@ -73,17 +73,19 @@ def current_cover_position(self):

@property
def device_class(self):
"""Define this cover as either window/blind/awning/shutter."""
if isinstance(self.node, Window):
return "window"
if isinstance(self.node, Blind):
return "blind"
if isinstance(self.node, RollerShutter):
return "shutter"
"""Define this cover as either awning, blind, garage, gate, shutter or window."""
if isinstance(self.node, Awning):
return "awning"
if isinstance(self.node, Blind):
return "blind"
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare May 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are constants in the cover entity integration for the valid device classes. Please import and use those here.

core/homeassistant/components/cover/__init__.py

Lines 43 to 52 in 4dcff29

DEVICE_CLASS_AWNING = "awning"
DEVICE_CLASS_BLIND = "blind"
DEVICE_CLASS_CURTAIN = "curtain"
DEVICE_CLASS_DAMPER = "damper"
DEVICE_CLASS_DOOR = "door"
DEVICE_CLASS_GARAGE = "garage"
DEVICE_CLASS_GATE = "gate"
DEVICE_CLASS_SHADE = "shade"
DEVICE_CLASS_SHUTTER = "shutter"
DEVICE_CLASS_WINDOW = "window"

if isinstance(self.node, GarageDoor):
return "garage"
if isinstance(self.node, Gate):
return "gate"
if isinstance(self.node, RollerShutter):
return "shutter"
if isinstance(self.node, Window):
return "window"
Copy link
Copy Markdown
Contributor

@Julius2342 Julius2342 Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, do you have any idea, why the velux windows are shown as shutters in apple home.

(which has the effect, that all windows open, when you say "hey siri, open the shutters". :-) )

Copy link
Copy Markdown
Contributor Author

@mnaggatz mnaggatz Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I don't know. I'm not quite there yet in my integration. I will definitely have a look at it, because I have Somfy roller shutters as well as Velux windows :-)

return "window"

@property
Expand Down