Add support for Velux Gates

[mnaggatz]

Breaking change

Proposed change

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[homeassistant]

Hi @mnaggatz,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[probot-home-assistant]

Hey there @Julius2342, mind taking a look at this pull request as its been labeled with a integration (velux) you are listed as a codeowner for? Thanks!

[Julius2342]

Looks good. (No idea why the tests fail)

[Julius2342]

btw, do you have any idea, why the velux windows are shown as shutters in apple home.

(which has the effect, that all windows open, when you say "hey siri, open the shutters". :-) )

[mnaggatz]

I'm sorry, I don't know. I'm not quite there yet in my integration. I will definitely have a look at it, because I have Somfy roller shutters as well as Velux windows :-)

[mnaggatz]

How can I start the test again? I can not see any errors belonging to my changes.

[frenck]

@mnaggatz Please rebase your PR on the latest dev branch in order to do that 👍

[mnaggatz]

After two attempts, it finally worked. Thanks for the advice.

[mnaggatz]

What is the further procedure? Is there anything else I need to do in order for the pull request to be executed?

[frenck]

Thanks, @mnaggatz! Looks good!

Oh, btw, nice first-time contribution to the project! Welcome! 🎉

[MartinHjelmare]

Please address the comment in a new PR. Thanks!

[MartinHjelmare]

There are constants in the cover entity integration for the valid device classes. Please import and use those here.

core/homeassistant/components/cover/__init__.py

Lines 43 to 52 in 4dcff29

	DEVICE_CLASS_AWNING = "awning"
	DEVICE_CLASS_BLIND = "blind"
	DEVICE_CLASS_CURTAIN = "curtain"
	DEVICE_CLASS_DAMPER = "damper"
	DEVICE_CLASS_DOOR = "door"
	DEVICE_CLASS_GARAGE = "garage"
	DEVICE_CLASS_GATE = "gate"
	DEVICE_CLASS_SHADE = "shade"
	DEVICE_CLASS_SHUTTER = "shutter"
	DEVICE_CLASS_WINDOW = "window"