Use config entry id for unique id if serial number is missing#34154
Merged
balloob merged 8 commits intohome-assistant:devfrom Apr 16, 2020
Merged
Use config entry id for unique id if serial number is missing#34154balloob merged 8 commits intohome-assistant:devfrom
balloob merged 8 commits intohome-assistant:devfrom
Conversation
probot-home-assistant
Bot
added
has-tests
integration: nut
small-pr
frenck
reviewed
Apr 14, 2020
20 tasks
bdraco
changed the title
balloob
reviewed
Apr 16, 2020
If the device is missing a serial number we fallback to the host/port/alias as the sensors will not show up on the integrations page which was confusing.
bdraco
changed the title
Member
Author
|
For 0.108.6 backport, only |
balloob
approved these changes
Apr 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
If the device is missing a serial number
we fallback config entry id as
the sensors will not show up on the
integrations page which was confusing.
This turned out to be much more common
then expected. I don't love this solution
and I'd be much happier if there is a better way.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: