Skip to content

Add tests for additional nut ups models#34240

Merged
bdraco merged 6 commits intohome-assistant:devfrom
bdraco:nut_more_ups_models
Apr 16, 2020
Merged

Add tests for additional nut ups models#34240
bdraco merged 6 commits intohome-assistant:devfrom
bdraco:nut_more_ups_models

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 15, 2020

Proposed change

Add tests for additional NUT ups models.

Fixes the missing display resource

Validates additional UPS in #33944

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco bdraco marked this pull request as draft April 15, 2020 15:17
@bdraco bdraco marked this pull request as ready for review April 16, 2020 00:08
@bdraco bdraco changed the title Add tests for additional NUT ups models Add tests for additional nut ups models Apr 16, 2020
@bdraco bdraco merged commit 188f3e3 into home-assistant:dev Apr 16, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants