Add play_media channel support to roku#34124
Merged
springstan merged 1 commit intohome-assistant:devfrom Apr 13, 2020
Merged
Conversation
|
Hey there @ctalkington, mind taking a look at this pull request as its been labeled with a integration ( |
This was referenced Apr 13, 2020
ctalkington
approved these changes
Apr 13, 2020
Contributor
ctalkington
left a comment
There was a problem hiding this comment.
this code looks ok to me, not sstup for local testing. I still need to add some initial code tests for the media player main services so ill do that during 109 beta shouldnt hold this up.
Member
|
Please update the documentation for roku to include this change, thanks :) |
Contributor
Author
|
It's done, maybe I didn't tag it correctly. #12902 |
springstan
approved these changes
Apr 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Support for media_player.play_media service for Roku! Currently only supports channels. Allows users to specify specific digital tuner channel for their tv to display. Modeled after DirecTV integration.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: