Skip to content

Add roku direct tuner channel selection#34123

Closed
quinnhosler wants to merge 1 commit intohome-assistant:devfrom
quinnhosler:roku-tuner-channel-select
Closed

Add roku direct tuner channel selection#34123
quinnhosler wants to merge 1 commit intohome-assistant:devfrom
quinnhosler:roku-tuner-channel-select

Conversation

@quinnhosler
Copy link
Copy Markdown
Contributor

Proposed change

The Roku media_player component already supports media_player.select_source for many apps and inputs. However, it lacked the ability to specify the desired antenna/digital tuner channel through this service, even though this is supported roku and the python module. This small change enables the media_player.select_source service to change to the desired channel given correctly formatted input.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

See Roku documentation for proper formatting in selecting tuner channel (already referenced in documentation)

entity_id: media_player.tv
source: tvinput.dtv?ch=5.1
  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @ctalkington, mind taking a look at this pull request as its been labeled with a integration (roku) you are listed as a codeowner for? Thanks!

@ctalkington
Copy link
Copy Markdown
Contributor

ctalkington commented Apr 13, 2020

I belive this should use play_media service instead see how directv implements:

async def async_play_media(self, media_type, media_id, **kwargs):
"""Select input source."""
if media_type != MEDIA_TYPE_CHANNEL:
_LOGGER.error(
"Invalid media type %s. Only %s is supported",
media_type,
MEDIA_TYPE_CHANNEL,
)
return
_LOGGER.debug("Changing channel on %s to %s", self._name, media_id)
await self.dtv.tune(media_id, self._address)

@MartinHjelmare MartinHjelmare changed the title roku direct tuner channel selection Add roku direct tuner channel selection Apr 13, 2020
@quinnhosler
Copy link
Copy Markdown
Contributor Author

I think you're right! #34124

@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants