Add roku direct tuner channel selection#34123
Closed
quinnhosler wants to merge 1 commit intohome-assistant:devfrom
Closed
Add roku direct tuner channel selection#34123quinnhosler wants to merge 1 commit intohome-assistant:devfrom
quinnhosler wants to merge 1 commit intohome-assistant:devfrom
Conversation
|
Hey there @ctalkington, mind taking a look at this pull request as its been labeled with a integration ( |
Contributor
|
I belive this should use play_media service instead see how directv implements: core/homeassistant/components/directv/media_player.py Lines 320 to 331 in ab1eda7 |
Contributor
Author
|
I think you're right! #34124 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The Roku media_player component already supports media_player.select_source for many apps and inputs. However, it lacked the ability to specify the desired antenna/digital tuner channel through this service, even though this is supported roku and the python module. This small change enables the media_player.select_source service to change to the desired channel given correctly formatted input.
Type of change
Additional information
See Roku documentation for proper formatting in selecting tuner channel (already referenced in documentation)
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: